feat: warning on linked requirement delete #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dovalid
approved these changes
May 17, 2024
FBalint
added a commit
that referenced
this pull request
May 23, 2024
* feat(AddRequirement): support for displaying provided dynamic value during setup * feat(DynamicRewardModal): support value provider requirements * extract & dynamic import DataProviderRequirement from new component * feat: dynamic setup button & base value selector WIP * feat: BaseValueModal with Add requirement btn * refactor(AddRoleRewardModal): WIP * feat(DynamicRewardModal): reward amount calculation breakdown (#1213) * feat(DynamicRewardModal): reward amount calculation breakdown * feat(PointsReward): calculate dynamic reward amount * fix(PointsReward): add optional chaining * refactor(PointsReward): batch score calculation into memo fn with early return * fix(PointsReward): "some" fallback if the role is not held * cleanup: remove useMembership changes, use existing prop * abstract into useDynamicRewardUserAmount hook * DynamicRewardCalculationTable: add not connected fallback * UI: move DynamicTag to same row if there's enough space & modal info footer whitespace * fix(CalculationTable): handle fallback if connected but there's no provided value --------- Co-authored-by: valid <valid@zgen.hu> * feat: warning on linked requirement delete (#1214) * feat: warning on linked requirement delete * refactor: extract ExistingRequirementDeleteAlert & useHasLinkedReward --------- Co-authored-by: valid <valid@zgen.hu> * feat: submit dynamic point reward * fix: show images on conversion step & minor fixes * feat: EditDynamicRewardModal * fix: display conversion value flooring warning message only when necessary * fix: round down point amount * feat(InformationModal): info modal in dynamic reward setup * fix(InformationModal): light mode for illustration * fix: lint error * refactor: use AddRewardContext instead of jotai atom for target role * dynamic points setup into SetPointsAmount * UI: whitespace impros & shadow to border * cleanup(AddPointsPanel): variables order * UI(DynamicRewardModal): footerBg impros * fix(AddPointsPanel): disable continue btn if baseValue is not set * fix: minor copy change * fix(BaseValueModal): better copy about base values provided by reqs * pass targetRoleId to provider as prop, adjust disabled tooltip copy * feat(RolePlatforms): display dynamic tag on edit role panel --------- Co-authored-by: valid <valid@zgen.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.