Merged
Conversation
OnyxSkyscape
approved these changes
Mar 20, 2023
Contributor
OnyxSkyscape
left a comment
OnyxSkyscape
left a comment
There was a problem hiding this comment.
Tested on dev chain and applied to prod, ready for merging
Contributor
Author
|
CI/CD pipeline fails due to a compiler error in latest (1.70.0) nightly. Since nightly is pulled in from the dockerfile via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aims to close #116 via a runtime upgrade. What's missing is a storage migration implementation that removes dangling id's from the approved validator set. @OnyxSkyscape do you think that's an easy migration? This is quite a high priority change because there's someone who I cannot add as a validator, because I removed them first.