Migrate 'varfont/unsupported_axes' check from Google Fonts to Univers…

…al profile varfont/unsupported_axes: "Ensure VFs do not contain (yet) the ital axis."
guidoferreyra · Sep 6, 2024 · f7d17f1 · f7d17f1
1 parent ec2e187
commit f7d17f1
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,7 @@ A more detailed list of changes is available in the corresponding milestones for
   - **[varfont/consistent_axes]**: "Ensure that all variable font files have the same set of axes and axis ranges."
   - **[varfont/duplexed_axis_reflow]**: "Ensure VFs with duplexed axes do not vary horizontal advance."
   - **[varfont/instances_in_order]**: ""Ensure the font's instances are in the correct order."
+  - **[varfont/unsupported_axes]**: "Ensure VFs do not contain (yet) the ital axis."
   - **[vttclean]**: "There must not be VTT Talk sources in the font."
 
 #### Moved from Fontwerk to Universal profile

diff --git a/Lib/fontbakery/checks/varfont.py b/Lib/fontbakery/checks/varfont.py
@@ -180,7 +180,7 @@ def check_varfont_duplexed_axis_reflow(font, ttFont, config):
     proposal="https://github.com/fonttools/fontbakery/issues/2866",
 )
 def check_varfont_unsupported_axes(font):
-    """Ensure VFs do not contain the ital axis."""
+    """Ensure VFs do not contain (yet) the ital axis."""
     if font.ital_axis:
         yield FAIL, Message(
             "unsupported-ital",

diff --git a/Lib/fontbakery/profiles/adobefonts.py b/Lib/fontbakery/profiles/adobefonts.py
@@ -85,6 +85,7 @@
         "varfont/consistent_axes",
         "varfont/duplexed_axis_reflow",
         "varfont/instances_in_order",
+        "varfont/unsupported_axes",
         "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
         "vttclean",
     ],

diff --git a/Lib/fontbakery/profiles/fontbureau.py b/Lib/fontbakery/profiles/fontbureau.py
@@ -31,6 +31,7 @@
         "varfont/consistent_axes",
         "varfont/duplexed_axis_reflow",
         "varfont/instances_in_order",
+        "varfont/unsupported_axes",
         "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
         "vttclean",
     ],

diff --git a/Lib/fontbakery/profiles/googlefonts.py b/Lib/fontbakery/profiles/googlefonts.py
@@ -150,8 +150,6 @@
             "googlefonts:version_bump",
             "googlefonts:vertical_metrics",
             "googlefonts:vertical_metrics_regressions",
-            #
-            "varfont/unsupported_axes",
         ],
     },
     "configuration_defaults": {

diff --git a/Lib/fontbakery/profiles/microsoft.py b/Lib/fontbakery/profiles/microsoft.py
@@ -50,6 +50,7 @@
         "varfont/consistent_axes",
         "varfont/duplexed_axis_reflow",
         "varfont/instances_in_order",
+        "varfont/unsupported_axes",
         "vttclean",  # very similar to vtt_volt_data, may be a good idea to merge them.
     ],
     "sections": {

diff --git a/Lib/fontbakery/profiles/typenetwork.py b/Lib/fontbakery/profiles/typenetwork.py
@@ -65,6 +65,7 @@
         "ufo_unnecessary_fields",
         "varfont/duplexed_axis_reflow",
         "varfont/instances_in_order",
+        "varfont/unsupported_axes",
         "vtt_volt_data",  # Very similar to 'vttclean' check, it may be a good idea to merge them.
     ],
     "sections": {

diff --git a/Lib/fontbakery/profiles/universal.py b/Lib/fontbakery/profiles/universal.py
@@ -87,6 +87,7 @@
             "varfont/consistent_axes",
             "varfont/duplexed_axis_reflow",
             "varfont/instances_in_order",
+            "varfont/unsupported_axes",
             "vtt_volt_data",  # very similar to vttclean, may be a good idea to merge them.
             "vttclean",
             "whitespace_glyphnames",

diff --git a/tests/test_checks_varfont.py b/tests/test_checks_varfont.py
@@ -46,7 +46,7 @@ def test_check_varfont_duplexed_axis_reflow():
 
 
 def test_check_varfont_unsupported_axes():
-    """Ensure VFs do not contain opsz or ital axes."""
+    """Ensure VFs do not contain (yet) the ital axis."""
     check = CheckTester("varfont/unsupported_axes")
 
     # Our reference varfont, CabinVFBeta.ttf, lacks 'ital' and 'slnt' variation axes.