Skip to content

Commit

Permalink
use / instead of _ on iso15008 check-IDs
Browse files Browse the repository at this point in the history
  • Loading branch information
felipesanches committed Sep 6, 2024
1 parent 05a6652 commit e456e95
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
10 changes: 5 additions & 5 deletions Lib/fontbakery/checks/iso15008.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def pair_kerning(font, left, right):


@check(
id="iso15008_proportions",
id="iso15008/proportions",
rationale="""
According to ISO 15008, fonts used for in-car displays should not be
too narrow or too wide.
Expand Down Expand Up @@ -114,7 +114,7 @@ def check_iso15008_proportions(ttFont):


@check(
id="iso15008_stem_width",
id="iso15008/stem_width",
rationale="""
According to ISO 15008, fonts used for in-car displays should
not be too light or too bold.
Expand Down Expand Up @@ -146,7 +146,7 @@ def check_iso15008_stem_width(ttFont):


@check(
id="iso15008_intercharacter_spacing",
id="iso15008/intercharacter_spacing",
rationale="""
According to ISO 15008, fonts used for in-car displays should not
be too narrow or too wide.
Expand Down Expand Up @@ -232,7 +232,7 @@ def check_iso15008_intercharacter_spacing(font, ttFont):


@check(
id="iso15008_interword_spacing",
id="iso15008/interword_spacing",
rationale="""
According to ISO 15008, fonts used for in-car displays
should not be too narrow or too wide.
Expand Down Expand Up @@ -284,7 +284,7 @@ def check_iso15008_interword_spacing(font, ttFont):


@check(
id="iso15008_interline_spacing",
id="iso15008/interline_spacing",
rationale="""
According to ISO 15008, fonts used for in-car displays
should not be too narrow or too wide.
Expand Down
10 changes: 5 additions & 5 deletions Lib/fontbakery/profiles/iso15008.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
PROFILE = {
"sections": {
"ISO15008": [
"iso15008_intercharacter_spacing",
"iso15008_interline_spacing",
"iso15008_interword_spacing",
"iso15008_proportions",
"iso15008_stem_width",
"iso15008/intercharacter_spacing",
"iso15008/interline_spacing",
"iso15008/interword_spacing",
"iso15008/proportions",
"iso15008/stem_width",
]
}
}
10 changes: 5 additions & 5 deletions tests/test_checks_iso15008.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_extra_needed_exit(monkeypatch):

def test_check_iso15008_proportions():
"""Check if 0.65 => (H width / H height) => 0.80"""
check = CheckTester("iso15008_proportions")
check = CheckTester("iso15008/proportions")

# Cabin has a proportion of 0.7, so that's good.
font = TEST_FILE("cabin/Cabin-Regular.ttf")
Expand All @@ -54,7 +54,7 @@ def test_check_iso15008_proportions():

def test_check_iso15008_stem_width():
"""Check if 0.10 <= (stem width / ascender) <= 0.82"""
check = CheckTester("iso15008_stem_width")
check = CheckTester("iso15008/stem_width")

font = TEST_FILE("cabin/Cabin-SemiBold.ttf")
assert_PASS(check(font), "with a good font...")
Expand All @@ -77,7 +77,7 @@ def test_check_iso15008_stem_width():

def test_check_iso15008_intercharacter_spacing():
"""Check if spacing between characters is adequate for display use"""
check = CheckTester("iso15008_intercharacter_spacing")
check = CheckTester("iso15008/intercharacter_spacing")

font = TEST_FILE("cabin/Cabin-Regular.ttf")
assert_PASS(check(font), "with a good font...")
Expand Down Expand Up @@ -113,7 +113,7 @@ def test_check_iso15008_intercharacter_spacing():

def test_check_iso15008_interword_spacing():
"""Check if spacing between words is adequate for display use"""
check = CheckTester("iso15008_interword_spacing")
check = CheckTester("iso15008/interword_spacing")

font = TEST_FILE("cabin/CabinCondensed-Bold.ttf")
# lm space is 112; m+space+l space is 286; 286/112 = 255%
Expand All @@ -128,7 +128,7 @@ def test_check_iso15008_interword_spacing():

def test_check_iso15008_interline_spacing():
"""Check if spacing between lines is adequate for display use"""
check = CheckTester("iso15008_interline_spacing")
check = CheckTester("iso15008/interline_spacing")

font = TEST_FILE("cabin/Cabin-Regular.ttf")
assert_PASS(check(font), "with a good font...")
Expand Down

0 comments on commit e456e95

Please sign in to comment.