fix: simplify voiceOver.navigateToWebContent() now auto-navigation is disabled by default - #46
Merged
Merged
Conversation
…tion should be disabled
…ctive element (meaning will later track focus)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #43
Details
We are seeing issues with
voiceOver.navigateToWebContent()where the use ofVO-Shift-Homewhich backsmoveToBeginningOfTextis moving user's cursor to the top of the window instead of the beginning of the text (something that appears to be a common issue reported on forums such as AppleVis).Reading https://support.apple.com/en-gb/guide/voiceover/cpvokys04/mac it could be that we actually want
VO-Home, but instead opting to remove this step altogether as it was initially introduced due to VO default web content behaviour of auto-navigating.Auto-navigation should now be disabled by default as of
@guidepup/guidepup@0.29.0(https://github.com/guidepup/guidepup/releases#release-0.29.0), so we should be able to now just rely on the web content search and interaction steps to place us at the beginning of the web content without trying to "move to left" at any point.CheckList