Adds precision option for datetime fields, reverts new default functionality from v4.1.1 and makes it opt-in #71
+152
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, and restores the previous default
fusion2004
force-pushed
the
opt-into-high-precision-datetime-field-casting
branch
from
c1b6b3a to
4ff2217
Compare
jrichardlai
approved these changes
Nov 11, 2024
fusion2004
deleted the
opt-into-high-precision-datetime-field-casting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields using the time/timestamp/datetime caster will now default back to the old behavior, and use a
precision:option to opt-in to the new behavior introduced inv4.1.1.precision: :secondswill retain the old behavior of always parsing to a new Time objectwith floored sub-second precision, but applied more forcefully than before as it would have parsed whatever you passed to it. (This is the default, now.)
precision: :highwill now use the new functionality of re-using Time objects when theyare passed in, or if not parsing exactly the provided string as to a Time object.