Skip to content

Conversation

@mnelson
Copy link
Collaborator

@mnelson mnelson commented Sep 30, 2024

No description provided.

@mnelson mnelson enabled auto-merge (squash) September 30, 2024 21:48
@mnelson mnelson changed the title Make inheritable options inheritable Make inheritable options configurable Sep 30, 2024
Copy link

@ramirorinaldi ramirorinaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test inheritable_field_options and inheritable_field_options?

@mnelson mnelson disabled auto-merge October 1, 2024 14:45
@mnelson mnelson enabled auto-merge (squash) October 1, 2024 14:45
@mnelson
Copy link
Collaborator Author

mnelson commented Oct 1, 2024

Is there a way to test inheritable_field_options and inheritable_field_options?

Added a test on the association fields to ensure things were inherited.

@rodocontegni
Copy link

our second-class eng reviews don't count

@mnelson mnelson merged commit f0b1a7f into main Nov 5, 2024
4 checks passed
@mnelson mnelson deleted the inheritable-options branch November 5, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants