[Bug] Missing support for AzureAI #770
Conversation
| from typing import Type | ||
| from urllib.parse import parse_qs, urlparse | ||
|
|
||
| import tiktoken |
There was a problem hiding this comment.
If we're getting rid of a hard openai dependency, we may have to do an optional import check here too
There was a problem hiding this comment.
tiktoken is still a hard dependency.... should that change?
| model : str | ||
| The name of the OpenAI model to use (e.g. gpt-3.5-turbo). |
There was a problem hiding this comment.
Are we assuming users will use the openAI naming scheme when supplying this info, even if their deployment is named something different?
There was a problem hiding this comment.
They have to. This is supposed to be the name in the drop down when they deploy the model:
|
I think updating the notebooks (and possibly adding a README example?) here would be good too |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 68.97% 62.47% -6.50%
==========================================
Files 55 55
Lines 4058 4067 +9
==========================================
- Hits 2799 2541 -258
- Misses 1259 1526 +267 ☔ View full report in Codecov by Sentry. |
|
Updated notebooks, and the documentation on the |
|
Will merge in the morning, unless there are further objections. |
AzureAI changed how their playground shows how to call their OpenAI models. Make sure that we support this. Extra tests have been added, extra documentation to the
AzureOpenAIclass itself, and also updates to the notebook tests.