Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teeny-tiny little PR: make
Null
inherit fromTerminal
.As far as I can tell, this is only really useful for preventing something rather silly from blowing up:
Why would you write this? Don't ask.
Currently, calling this will raise an
AttributeError: 'Null' object has no attribute 'values'
whenreplace_grammar_node
does its thing.An alternative fix would be to explicitly add
Null
to thisisinstance
check inreplace_grammar_node
:But I think that this PR is a bit more elegant (unless anyone can think of a reason that
Null
wouldn't beTerminal
).All tests passing on my end :)