Round 4 of test conversions #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# 12 feature
Just set the object.
Potentially fewer allocations, as well
Bump nuget packages. Tests confirmed still passing.
Should probably be split up into multiple tests or at least have tests added for the individual actions it takes to prove them in isolation.
Assert end is identical to start Also use the OperationManager so the state of the stacks can be tested
Each part is a local function so it's all easier to visually parse now
…nit-tests-to-constraint-model-4 * 19-convert-postests-to-constraint-model: Add Heya to the dictionary so it stops getting reported as an error Turn that into a switch Wrap these in assertions that they don't throw Use nameof on this usings for disposables Might as well let this test all combinations of the old inputs Remove two redundant tests Add nullability adornment Remove unneeded usings Use collection expressions for these
…nvert-unit-tests-to-constraint-model-4 * 36-convert-radiogrouptests-to-constraint-model: Convert these Statics and collection expressions Annotate the fixture
…nvert-unit-tests-to-constraint-model-4 * 37-convert-scrollviewtests-to-constraint-model: Minor cleanup and modernizing Convert the assertions fixture annotations Ain't nobody got time for that
…onvert-unit-tests-to-constraint-model-4 * 38-convert-spinnerviewtests-to-constraint-model: Clean up after ourselves Use the standard style for this Make these assumptions Dispose it before the last assertion Convert to constraints Annotations Clean usings and switch to file-scoped namespace
Contributor
Author
|
As with the last one, I'm branching from here for work from this point, so this PR will remain as-is. New branch will be convert-unit-tests-to-constraint-model-5, and I'll open a PR for that when I have a few test fixtures done in it. |
Contributor
Author
|
This is obsoleted by #283, but feel free to handle them however you please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has several more test fixtures converted and slightly improved.
Ready for merge whenever