Skip to content

Fixes #4485 toggle cell happening on every mouse click#4692

Open
tznind wants to merge 7 commits intogui-cs:v2_developfrom
tznind:4485-fix
Open

Fixes #4485 toggle cell happening on every mouse click#4692
tznind wants to merge 7 commits intogui-cs:v2_developfrom
tznind:4485-fix

Conversation

@tznind
Copy link
Collaborator

@tznind tznind commented Feb 6, 2026

Fixes

Proposed Changes/Todos

  • Todo 1

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind requested a review from tig as a code owner February 6, 2026 19:40
@tznind tznind marked this pull request as draft February 6, 2026 19:42
@tig
Copy link
Collaborator

tig commented Feb 6, 2026

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.34%. Comparing base (eba9bb6) to head (71bc8c4).

Additional details and impacted files
@@              Coverage Diff               @@
##           v2_develop    #4692      +/-   ##
==============================================
+ Coverage       77.32%   77.34%   +0.01%     
==============================================
  Files             447      447              
  Lines           45033    45033              
  Branches         6543     6543              
==============================================
+ Hits            34821    34829       +8     
+ Misses           8326     8322       -4     
+ Partials         1886     1882       -4     
Files with missing lines Coverage Δ
Terminal.Gui/Views/FileDialogs/FileDialog.cs 52.33% <100.00%> (-0.46%) ⬇️
....Gui/Views/TableView/CheckBoxTableSourceWrapper.cs 55.12% <100.00%> (ø)
Terminal.Gui/Views/TableView/TableView.cs 84.41% <100.00%> (+0.19%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba9bb6...71bc8c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tig
Copy link
Collaborator

tig commented Feb 6, 2026

And can you add unit tests so this stays fixed?

@tznind
Copy link
Collaborator Author

tznind commented Feb 6, 2026

Sorry should have created as draft, its a WIP

@tznind tznind changed the title Fix toggle cell happening on every mouse click Fixes #4485 toggle cell happening on every mouse click Feb 6, 2026
@tznind tznind marked this pull request as ready for review February 6, 2026 20:08
@tznind
Copy link
Collaborator Author

tznind commented Feb 6, 2026

  • Checkboxes continue to work correctly in TableEditor
  • When using Multiple in FileDialog you can select multiple files with Space
Screenshot 2026-02-06 201051

selecting 3 files

Hmn hold up just spotted another bug although probably an old one, the radio button option in table editor seems to just flip checkboxes too.

Actually it works:

  • if you toggle checkboxes on and then off
  • if you toggle radio on and then off
  • if you always toggle the last one off before toggling next one on

But

  • It doesn't work to flip between the two.

I can dig into it at some point - probably best as a seperate issue.

@tznind tznind marked this pull request as draft February 6, 2026 20:14
@tznind tznind marked this pull request as ready for review February 6, 2026 20:19
@tznind
Copy link
Collaborator Author

tznind commented Feb 8, 2026

This is ready for review when you get a chance @tig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle is on by default and is horrible (TableView)

2 participants