Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preps for and partially Fixes #2491 - Refactors Toplevel and Application Navigation #3634

Merged
merged 88 commits into from
Aug 5, 2024
Merged

Preps for and partially Fixes #2491 - Refactors Toplevel and Application Navigation #3634

merged 88 commits into from
Aug 5, 2024

Commits on Jul 21, 2024

  1. Initial commit.

    @tig
    tig committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f328f0c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'v2_develop' into v2_2491-Toplevel-Redesign

    @tig
    tig authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    14d8bf5 View commit details
    Browse the repository at this point in the history

  2. Refactored Application into smaller files. 

    Made Application #nullable enable
    @tig
    tig committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    44ce74a View commit details
    Browse the repository at this point in the history

  3. Fixed nullable warnings

    @tig
    tig committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2e0a9a7 View commit details
    Browse the repository at this point in the history

  4. Applicaation Toplevel handling moved to separate file

    @tig
    tig committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0b8e434 View commit details
    Browse the repository at this point in the history

  5. Added Toplevel to spelling dict

    @tig
    tig committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2939108 View commit details
    Browse the repository at this point in the history

  6. Toplevel cleanup

    @tig
    tig committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    250050c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Toplevel.cs organization

    @tig
    tig committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4701080 View commit details
    Browse the repository at this point in the history

  2. More Toplevel.cs organization & docs

    @tig
    tig committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d44e8d3 View commit details
    Browse the repository at this point in the history

  3. Fixed dumb enum cast in KeyBinding code

    @tig
    tig committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d813b1f View commit details
    Browse the repository at this point in the history

  4. More Toplevel.cs organization & docs

    @tig
    tig committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fe5cbe4 View commit details
    Browse the repository at this point in the history

  5. More Toplevel.cs organization & docs

    @tig
    tig committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f8e8aff View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. WIP (Very Broken) try to move keybindings out of Toplevel to app

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    feaf5c0 View commit details
    Browse the repository at this point in the history

  2. Moved Toplevel keybindings out of Toplevel to Application. 

    Still need to move navigation code out of Toplevel
    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c03dd32 View commit details
    Browse the repository at this point in the history

  3. removed un needed key handling code from TextView

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    22dcbc1 View commit details
    Browse the repository at this point in the history

  4. removed unneeded key handling code from Toplevel

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c088f2e View commit details
    Browse the repository at this point in the history

  5. removed unneeded AlternateBack/FormardKey code from Toplevel

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4a56b84 View commit details
    Browse the repository at this point in the history

  6. Moved view navigation out of Toplevel and into Application (via ViewN… 

    …avigation static class).
    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0c56dfe View commit details
    Browse the repository at this point in the history

  7. Fixed nullable warnings 2

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    73a9dc3 View commit details
    Browse the repository at this point in the history

  8. Fixed nullable warnings 3

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    04dbe68 View commit details
    Browse the repository at this point in the history

  9. Fixed nullable warnings 4

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3b35189 View commit details
    Browse the repository at this point in the history

  10. Fixed nullable warnings 5

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    689c0cd View commit details
    Browse the repository at this point in the history

  11. Fixed nullable warnings 6

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ff47aa2 View commit details
    Browse the repository at this point in the history

  12. Fixed nullable warnings 7

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    022050d View commit details
    Browse the repository at this point in the history

  13. Moved Overlapped stuff to ApplicationOverlap static class. Fixed null… 

    …able warnings.
    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f37ec5e View commit details
    Browse the repository at this point in the history

  14. Moved Overlapped stuff to ApplicationOverlap static class. Fixed null… 

    …able warnings.
    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cb3e806 View commit details
    Browse the repository at this point in the history

  15. Moved Overlapped stuff to ApplicationOverlap static class. Fixed null… 

    …able warnings.
    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cbecae5 View commit details
    Browse the repository at this point in the history

  16. nullable enable TopLevel

    @tig
    tig committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    331d972 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. WIP: Modify Focus logic to properly deal with ViewArrangement.Overlap… 

    …ped.
    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ca4d10b View commit details
    Browse the repository at this point in the history

  2. WIP: More - Modify Focus logic to properly deal with ViewArrangement.… 

    …Overlapped.
    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3a40851 View commit details
    Browse the repository at this point in the history

  3. Reorganized View source files to get my head straight

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d874f56 View commit details
    Browse the repository at this point in the history

  4. Code cleanup and API docs - getting better understanding of navigatio… 

    …n code.
    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9b89fe6 View commit details
    Browse the repository at this point in the history

  5. Documenting focus code

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ccec0ee View commit details
    Browse the repository at this point in the history

  6. Documenting focus code

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    15e6b4e View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'refs/remotes/origin/v2_2491-Toplevel-Re… 

    …design' into v2_2491-Toplevel-Redesign
    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a935ef8 View commit details
    Browse the repository at this point in the history

  8. Fixed post merge errors.

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    78f527e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'v2_2491-Toplevel-Redesign' into v2_2491-Arrangement-Ove… 

    …rlapped
    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5b1ac0e View commit details
    Browse the repository at this point in the history

  10. Prepping to reduce duplicated code in FocusNext/Prev

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4b785c8 View commit details
    Browse the repository at this point in the history

  11. Reduced duplicated code by leverating Navigationdirection enum

    @tig
    tig committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    66f83ad View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Rewrote FocusNearestView to be understandable

    @tig
    tig committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    911f2c6 View commit details
    Browse the repository at this point in the history

  2. Renamed FocusNearestView to be understandable

    @tig
    tig committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    aa9d42f View commit details
    Browse the repository at this point in the history

  3. Added low-level Focus tests

    @tig
    tig committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3f19a6f View commit details
    Browse the repository at this point in the history

  4. Added low-level Focus tests

    @tig
    tig committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    5e28ba1 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Progress

    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ee3c48a View commit details
    Browse the repository at this point in the history

  2. Fixed unit test

    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    207266b View commit details
    Browse the repository at this point in the history

  3. Removed coupling between TabStop and CanFocus

    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    e41b24f View commit details
    Browse the repository at this point in the history

  4. Converted TabStop to auto property

    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    5d1467d View commit details
    Browse the repository at this point in the history

  5. TabStop -> now of type TabStop. 

    Updated unit tests.
    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    4ede064 View commit details
    Browse the repository at this point in the history

  6. Added BUGBUGs and TODOs re TabIndex

    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    fa4b9dc View commit details
    Browse the repository at this point in the history

  7. Changed semantics of TabIndexes, TabIndex, and CanFocus relative to T… 

    …abStop.

CanFocus is not coupled with the tab index or tab stop other than to automatically set TabStop when set to True.
A TabIndex of -1 is only used to indicate TabStop_set has not been called.
Once nullable is enabled, we'll change _tabIndex to be nullable.
Changing CanFocus does not impact TabIndex (except in that it sets TabStop if it's None).
    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    d507426 View commit details
    Browse the repository at this point in the history

  8. Made View.Navigation nullable enable. 

    Changed TabIndex to int?.
Changed TabStop to int?.
Changed TabStop flags.
    @tig
    tig committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    d407683 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. WIP: Refining TabStop and GroupStop

    @tig
    tig committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    65592b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. WIP: More refining

    @tig
    tig committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f2eb9ce View commit details
    Browse the repository at this point in the history

  2. WIP: Fixed stuff. Broke stuff. Making progress.

    @tig
    tig committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    cf1435a View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. WIP: More. Trying to fix TableView regression

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    37f3490 View commit details
    Browse the repository at this point in the history

  2. Fixed FileDialog test

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6c889c9 View commit details
    Browse the repository at this point in the history

  3. Added BUGBUGs

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3d00102 View commit details
    Browse the repository at this point in the history

  4. Added AllViews_AtLeastOneNavKey_Leaves

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    47e1c87 View commit details
    Browse the repository at this point in the history

  5. Added AllViews_AtLeastOneNavKey_Leaves

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    38e517c View commit details
    Browse the repository at this point in the history

  6. Cleaned up some unit tests

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6f4c7be View commit details
    Browse the repository at this point in the history

  7. Revamped Scenario

    @tig
    tig committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    469b357 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Code cleanup

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    2f71fc0 View commit details
    Browse the repository at this point in the history

  2. Changed Shortcuts scenario to use Ctrl-F4 to exit instead of Ctrl-Z a… 

    …s that's used for suspend on linux/mac
    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    25018b7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v2_develop' into v2_2491-Refactor-TopLevel-Application-… 

    …And-Focus
    @tig
    tig authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9a6e09f View commit details
    Browse the repository at this point in the history

  4. merged with v2_develop

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    bb16e69 View commit details
    Browse the repository at this point in the history

  5. Nuked AlternateFwd/BkKeys. 

    Added Next/PrevTabGroupKey.
Fixed tests.
    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    79e50b4 View commit details
    Browse the repository at this point in the history

  6. Added Next/PrevTabKeys. 

    Refactored ApplicationNavigation in prep for further work
    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8da833a View commit details
    Browse the repository at this point in the history

  7. backported adornmentseditor

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8cbbcd8 View commit details
    Browse the repository at this point in the history

  8. backported ViewExperiments

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    eaa5b01 View commit details
    Browse the repository at this point in the history

  9. Enabled ViewArrangement.Overlapped zorder hack

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    09c1003 View commit details
    Browse the repository at this point in the history

  10. Updated Window.Arrangement

    @tig
    tig committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ac9d011 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Hacked in Application.Navigation.Set/GetFocused

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    4985da4 View commit details
    Browse the repository at this point in the history

  2. Fixed hack

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    288e3fb View commit details
    Browse the repository at this point in the history

  3. Fixed KeyBinding issue @BDisp found

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    8772645 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'v2_develop' into v2_2491-Refactor-TopLevel-Application-… 

    …And-Focus
    @tig
    tig authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    bbe8fbf View commit details
    Browse the repository at this point in the history

  5. Code cleanup & doc fix

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    5f567be View commit details
    Browse the repository at this point in the history

  6. Merge branch 'v2_2491-Refactor-TopLevel-Application-And-Focus' of tig… 

    …:tig/Terminal.Gui into v2_2491-Refactor-TopLevel-Application-And-Focus
    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    18997e0 View commit details
    Browse the repository at this point in the history

  7. Back ported navigation.md

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    3072d8b View commit details
    Browse the repository at this point in the history

  8. Doc updates

    @tig
    tig committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    8c14ab3 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Merge branch 'v2_develop' into v2_2491-Refactor-TopLevel-Application-… 

    …And-Focus
    @tig
    tig authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    fc05d06 View commit details
    Browse the repository at this point in the history

  2. Doc updates

    @tig
    tig committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    f70e8de View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v2_2491-Refactor-TopLevel-Application-And-Focus' of tig… 

    …:tig/Terminal.Gui into v2_2491-Refactor-TopLevel-Application-And-Focus
    @tig
    tig committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    bc1483e View commit details
    Browse the repository at this point in the history

  4. simplified test

    @tig
    tig committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    18ac4ab View commit details
    Browse the repository at this point in the history

  5. Found and fixed another Shortcut bug

    @tig
    tig committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    9526b4e View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Simplfiied app scope key setters

    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e86a2fc View commit details
    Browse the repository at this point in the history

  2. Updatd keyboard.md

    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    331ab51 View commit details
    Browse the repository at this point in the history

  3. Merged with v2_develop. 

    Code cleanup
    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9865f72 View commit details
    Browse the repository at this point in the history

  4. Fixed merged issue

    @tig
    tig committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    af9887b View commit details
    Browse the repository at this point in the history