Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3592. DateField unit tests fail on macos.latest. #3602

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 10, 2024

Fixes

Proposed Changes/Todos

  • Add conditional for macos

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 10, 2024 23:43
Copy link
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but a more formal/appropriate means of achieving platform-specific tests is to use per-platform test methods that have the [SupportedOSPlatform(string)] attribute applied.

For example: [SupportedOSPlatform("macos")]

There is also an inverse attribute available: `[UnsupportedOSPlatform(string)]'

Both can appear multiple times if multiple platforms need to be specified.

@dodexahedron
Copy link
Collaborator

That can be used in other code, too - not just tests, by the way.

@BDisp
Copy link
Collaborator Author

BDisp commented Jul 11, 2024

Your suggestion is to only run a unit test that only supports or does not support a certain platform. In this case it is a unit test that runs on all platforms (Windows, Linux and Mac) and there are only constraints in 3 situations on the Mac. I also prefer to use the OSPlatform enum because it is more generic.

@tig tig merged commit 425267b into gui-cs:v2_develop Jul 11, 2024
3 checks passed
@BDisp BDisp deleted the v2_3592_culture-unit-test-on-macos-fix branch July 11, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateField unit tests fail on macos.latest
3 participants