Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2249. CharacterMap isn't refreshing well non-BMP code points on scroll. #2673

Closed
wants to merge 70 commits into from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented May 25, 2023

Fixes #2249 - Many of the non-BMP code point only occupies 1 column, but driver read 2 chars and advance 2 columns. The trick is back off 1 column before write next chars.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

netdriver-non-bmp-fix

Pizza?

imagem

@tig
Copy link
Collaborator

tig commented May 26, 2023

Can you please target this at my PR #2612 instead of v2_develop?

As I indicated before I've made a tons of changes to the console drivers in #2612 and it will be very hard for me to merge new changes out of v2_develop. I'm working really hard on getting #2612 done so I can put it into v2_devleop but it will still be another week or so.

Thanks.

@BDisp
Copy link
Collaborator Author

BDisp commented May 26, 2023

Done @tig tig#13.

@tig tig closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants