Adds "Clip Region" clipping to ConsoleDriver
#2606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a draft. I've discovered a bunch of things in all the drivers that need to be tweaked to make this work. No way am I going to do it all 4 times. Instead, I'm going to work on #666 (which I started in the code in this PR) as a separate PR first. It's just crazy how much duplicate/similar code there are in all 4 drivers. Much can be moved into |
22 tasks
8 tasks
10 tasks
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new
Viewarchitecture, we will need a more sophisticated clipping mechanism than just a single rectangle.This PR adds such a thing, retaining the previous
ConsoleDriver.Clipfunctionality.The clip region is exposed via
ClipRegionwhich is aList<Rect>.IsInClipRegion()(private) tests whether a coordinate is within the region or not.ConsoleDriver.IsValidCliphas been renamed toIsValidLocation(it was mis-named before because it also validates the coordinates are within the screen bounds).Also:
Other than ensuring I didn't break anything and adding unit tests, I've not exercised this functionality for realz yet. That will come soon, hence this is still a draft PR.