-
Notifications
You must be signed in to change notification settings - Fork 720
Fixes #2150. Revamping FileDialog #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
208 commits
Select commit
Hold shift + click to select a range
d10101e
Investigating new file dialog
tznind 7d40047
Column sorting
tznind a6a997d
Add navigationStack
tznind 6212da6
Append autocomplete half working
tznind 4cf0dd3
Change autocomplete append to use draw effect instead of selection ef…
tznind e7370f1
WIP on FileDialog2
tznind f43e23c
Refactor sort order and add more 'ls' colors
tznind 66bf342
Refactor history to its own class
tznind 25cc8a8
FileDialog2 navigation fixes/improvements
tznind 258b1a9
Added centered Title
tznind e4f8865
Add tree view and split container
tznind 3ff0bf9
Add FileDialogState
tznind 2a82c16
Add AllowsMultipleSelection
tznind 1887e16
Add result fields and Scenario
tznind db428cd
Added FileDialo2 test file
tznind b42fa62
Merge branch 'develop' into fs
tznind dcc7cc2
Fix FileDialog2 Redraw padding to respect max/min view bounds
tznind 7a5191d
Fix unit tests and warnings
tznind aa873a9
Started on better keyboard navigation in FileDialog2
tznind 9539288
Merge branch 'splitcontainer' into fs
tznind a248c93
Update to match new SplitContainer API
tznind bfdb720
Quality of Life improvements
tznind 51eb85a
Fix recommending parent folder
tznind 5fa407d
Remove border from SplitContainer in FileDialog2 and fixed tests
tznind 3ed9583
Bugfixes and improvements to FileDialog2
tznind 761bd3a
usability improvements to FileDialog2
tznind cbb461e
Merge branch 'develop' into fs
tznind f547e34
Add multi select and OpenMode
tznind 7380aa9
Enforce OpenMode when making a multi selection
tznind ecad831
Prevent typing illegal characters
tznind 862f62f
Added AllowedTypes to FileDialog2
tznind 6a9c900
Added combo box filter AllowedType
tznind 4635fe3
Improve code readability by reordering members
tznind e29f37b
Do not update FileDialog2 text box when selecting ".." in TableView
tznind 00420f0
Fix history navigation in FileDialog2
tznind 5798858
Restore selection after navigating backwards in history
tznind 834fb99
Add FileDialog2 tests
tznind ad31a07
Make FileDialog2 Title user configurable
tznind 85dd834
Fix DirectTyping_Allowed unit test when running on linux
tznind 045eb8b
Change Home/End to go to first/last cell in table in FileDialog2
tznind af444c1
Remove overloaded Title property
tznind 8208ff3
Merge branch 'develop' into fs
tznind 90ab6ec
Switch to `ustring.IsNullOrEmpty`
tznind aad75db
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind e74beae
Merge branch 'splitcontainer' into fs
tznind d2446db
Update to latest TileView API
tznind f6ad599
Add TableView navigation by letter using CollectionNavigator
tznind 8bc83b9
Fix recreating search navigator too often
tznind d9e484b
Merge pull request #154 from tig/tznind-splitcontainer
tznind 67cdb56
Add tests for proper disposing
tznind 1407705
Make Ctrl+F10 toggle split line focusability
tznind c5243ff
Fix layout bug in first tile when orientation is horizontal
tznind 6f8ae9b
Merge branch 'develop' into splitcontainer
tznind 0d022da
Merge branch 'splitcontainer' of https://github.com/tznind/gui.cs int…
tznind 6f2ac69
Merge branch 'develop' into splitcontainer
tig 369cd67
merged line canvas etc
tig 67a9e05
Switch to GenerateImage
tznind 971062c
Merge branch 'develop' into splitcontainer
tig 3c3a014
Fix not calling base constructor
tznind edf766e
Merge branch 'splitcontainer' into tznind-splitcontainer
tznind 6be0972
Merge pull request #158 from tig/tznind-splitcontainer
tznind a068933
Revert "Merges latest LineCanvas into TileView"
tznind 44c6978
Merge pull request #160 from tznind/revert-158-tznind-splitcontainer
tznind ed17727
Fix keyboard tab navigation problems
tznind 7929084
Workaround for changing CanFocus throwing Exceptions sometimes
tznind bd066c0
Merge branch 'gui-cs:develop' into fs
tznind fb4e2fc
Merge branch 'splitcontainer' into fs
tznind f870764
Update to latest splitcontainer API
tznind 016e377
Adjust suggestions to be gray and properly update on keystrokes
tznind 33f9137
Move ok and cancel to bottom
tznind 2bf4463
Add MustExist and fix multi selection of 1 result
tznind f828ea3
bugfixes and quality of life
tznind 270d879
Navigating to .. clears path up to current dir
tznind d21b23e
Better arrow key navigation
tznind c35f956
Make title pretty and informative
tznind 9dcb34e
Fix test
tznind 8d255ff
Fix test
tznind 7e446ff
Merge branch 'develop' into fs
tznind e9a100c
Trim default Titles to be more compact and readable
tznind d182c66
Merge branch 'v2' into fs
tznind 8d62f39
Fix bad merge changes
tznind 80eb291
Remove EscSeqReq files that are not in v2... came from develop?!
tznind 5aef9fa
Fix nullable and enable toggle select on table view
tznind 95148f0
Fix multi select return value
tznind 0766f66
Add icon and monochrome support
tznind f73e985
Add search elements
tznind f077334
Add search for current directory
tznind a5c2554
Merge branch 'v2_develop' into fs
tznind 0cc4c27
WIP: Async search
tznind a2e5169
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind d05aa6d
Thread safety and disposal
tznind 6e1c436
Improve UX
tznind 76cdba7
Fix for rapid search results
tznind 4cc0c3a
Fix warnings and whitespace
tznind f670cc8
Don't add more than 10000 search results
tznind efd0041
Add support for adjusting search matching
tznind 9646e5b
Added ISearchMatcher example to FileDialog2Example
tznind b5f5127
Remove double spaces after periods
tznind 4cab118
Make MaxSearchResults a config setting
tznind 684102b
Localization for FileDialog2
tznind a163238
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind debff32
Fix build error
tznind f7f223e
Support for custom open button Text
tznind 3abffa8
Improve file dialog scenario UX
tznind 36503b6
Change feedback to a drawing effect in center of screen
tznind 0fd95bc
Merge branch 'v2_develop' into fs
tznind 085dff4
Explore MenuBar instead of ComboBox for AllowedTypes
tznind c493580
Fix prompt and move file open into try/catch for errors reading files
tznind f9fce97
Open menu when tabbed to
tznind 2512c21
Merge branch 'v2_develop' into fs
tznind be4e3ab
FileDialog2 improvements
tznind 7f452b2
Add style settings in scenario and make autocomplete case insensitive…
tznind 51c4bc9
Move ok button text to Style
tznind 1ea2e1b
xmldoc
tznind 5b9805e
Remove old FileDialog and re-wire OpenDialog and SaveDialog to use Fi…
tznind c532b49
localization
tznind 62a3257
Move open/save dialog to their own files
tznind bfd596a
Rename FileDialog2 to FileDialog
tznind 050a564
Fix repetition in string
tznind bc88614
Add IAllowedType
tznind 3aab5a8
Get rid of AllowedTypesIsStrict
tznind cab2128
Add max length to AllowedType ToString
tznind f6bc747
Pressing Enter in find restarts search instead of confirm selection
tznind 9c1a80e
Add TreeRootGetter for customizing the quick access items in FileDialog
tznind cedc4fb
Add FilesSelected event
tznind 382f978
Merge branch 'v2_develop' into fs
tznind b629d69
merge v2_develop into fs
tznind fb20edd
Update to new sender, event args signature
tznind 2f557f5
Fix naming on MouseEventArgs
tznind fe38c77
Merge branch 'events-mouse-fix' into fs
tznind 15182fe
Fix mouse events naming
tznind 97c50b5
Revert "Fix naming on MouseEventArgs"
tznind 8583bd4
Merge branch 'v2_develop' into fs
tznind 323c1cf
Add deletion support
tznind 10469e3
Move delete keybinding to tableview
tznind 6fc6a2e
Scaffold for rename and new operations
tznind 0051d7a
Prevent delete dialog popping up again on cancel
tznind 080a4cd
Add rename and new folder implementations
tznind 08e89d7
Add rename,delete,new to context menu
tznind c1a4a18
On rename or new, reselect the file in its new location in tree
tznind 123d186
Support searching on multiple terms
tznind 3ff7058
Localization support for new/rename/delete
tznind bc05775
Refactor internal classes and add class diagram
tznind 05d12cc
Move some visual properties to FileDialogStyle
tznind da63caa
Ensure MultiSelected is never null and always contains Path if relevant
tznind bffa647
Fix spacing/indentation
tznind e02881f
WIP: Add new namespace Terminal.Gui.FileServices
tznind 6a86ae2
Improve appearance of back/forward/up
tznind 1d78f57
Move SpinnerLabel to Views
tznind 9ee207c
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind e1e3e06
Add SpinnerView
tznind a0c02c6
Code formatting
tznind 172036f
Add AutoSpin test
tznind 3ee6760
Avoid ever removing spinner timeout twice
tznind 1f68487
Make SpinnerView show/hide instead of stopping
tznind e147012
Merge branch 'v2_develop' into spinner
tznind dda6dee
Merge branch 'spinner' into fs
tznind 4d8a261
Merge branch 'suggest-append' into fs
tznind 53fc7c2
Merge branch 'caption' into fs
tznind 544681a
WIP: Refactor to use 3 sub PRs
tznind a597eea
Add FilepathSuggestionGenerator
tznind 6d981ac
WIP: FileDialog autocomplete append mostly working again
tznind c2db954
Improve file autocomplete
tznind 20f773d
Move IconGetter to Style and provide default implementation
tznind 2b01a4c
Fix failing unit test
tznind 6bd8340
Improved colors and layout
tznind ebb1f74
Adjust use of unicode
tznind 6b59847
Merge branch 'v2_develop' into fs
tznind 82c1fca
Fix UseUnicodeCharacters
tznind 63ccc23
Update table style to include scroll indicators and lines
tznind 267121a
Fix cycle suggestion with down cursor
tznind 179c653
Adjust sort indicators
tznind eec04f9
Add default sort order on isDir then name
tznind 32369df
Always use left/right unicode arrows
tznind 043983c
Fix autocomplete suggesting in empty textbox
tznind b64ef67
Press escape to cancel ongoing search (when search box is focused)
tznind 1b05ac9
When entering a TreeView if there is no selection then select first o…
tznind 5411dd9
Move CursorIsAtEnd to TextField
tznind 9805ada
Improve layout
tznind 0ad3cbb
Change UseColors to be a cell color fill
tznind 1e44498
Merge branch 'table-cell-draw-fix' into fs
tznind f61f31b
Merge branch 'v2_develop' into fs
tznind 4093fb5
Fxied tests for new apis
tznind 5c799fc
Remove manual title drawing code
tznind a5f9c07
Fix MoveEnd name conflicting with base class
tznind 5b8ba95
Merge v2_develop into fs
tznind 5b15240
Fix merge conflicts
tznind 7d35ca8
Switched to IFileSystem for unit testing
tznind 8f0778c
Add unit test
tznind 7f19cd4
Revert "Fix MoveEnd name conflicting with base class"
tznind 489c338
Fix MoveEnd name collision with 'new' keyword
tznind 2bbcf18
Fixed tree not toggling
tznind 847626a
DateTime fixes and mocking
tznind a474588
Fix TestDirectoryContents_Windows
tznind 1960576
Expose UseColors and UseUnicodeCharacters as config settings
tznind 212d61e
Fix linter settings having removed curly brackets
tznind e7206b2
Fix namespace on test
tznind 30879c4
Move tests to file services folder
tznind 380e901
Remove the FileServices namespace
tznind ad7ebf3
Updated class diagram
tznind 0189a38
Clear title from tests for futureproofing
tznind a6c5743
Merge branch 'v2_develop' into fs
tznind 428c2ac
Localization support for FileDialog title
tznind 6ad0410
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind 0040338
Remove trailing whitespace in "open existing"
tznind 3ba344f
Merge branch 'v2_develop' into fs
tig 7081250
Fix listing suggestions immediately after folder path entered
tznind cf27b45
Merge branch 'fs' of https://github.com/tznind/gui.cs into fs
tznind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added centered Title
- Loading branch information
commit 258b1a914289ae7955d169203bf830171bc474f7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be consistent in your whitespace (blank lines). E.g. here you have none, a little further down you have 2.