Skip to content

Conversation

@BDisp
Copy link
Collaborator

@BDisp BDisp commented Oct 12, 2022

Fixes #2081 - I also included a json configuration file to allowing debugging unit tests on Linux with the VS 2022.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to document what testenvironments.json is for and why. Thanks.

@tig
Copy link
Collaborator

tig commented Oct 14, 2022

May also fix #1618

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 19, 2022

We need to document what testenvironments.json is for and why. Thanks.

Here is some documentation https://learn.microsoft.com/en-us/visualstudio/test/remote-testing?view=vs-2022. It's still in experimental preview.

Here a screenshot of the VS2022 where are the test. Much more reliable and faster than VSCode .

imagem

@tig
Copy link
Collaborator

tig commented Oct 20, 2022

@BDisp can you please add some comments in the code, at a logical place, that documents this for future contributors? (e.g. an XML comment in the .sln file?)

@BDisp
Copy link
Collaborator Author

BDisp commented Oct 20, 2022

@BDisp can you please add some comments in the code, at a logical place, that documents this for future contributors? (e.g. an XML comment in the .sln file?)

Thanks @tig. I ended for add the comments in the testenvironments.json file itself because normally no one read the comments in the solution.

@tig tig merged commit f155069 into gui-cs:develop Oct 21, 2022
@BDisp BDisp deleted the wsl-clipboard-unit-tests-fix branch October 21, 2022 02:03
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clipboard unit tests sometimes fail with WSL.

2 participants