Skip to content

Fixes #2069. Enable KeyDown and KeyUp events to be canceled (like KeyPress) #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fixes #2069. Enable KeyDown and KeyUp events to be canceled (like KeyPress) #2070

merged 2 commits into from
Sep 29, 2022

Conversation

@BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 27, 2022

Fixes #2069 - Now it's possible to cancel any key on the KeyDown and KeyUp events, like KeyPress event does.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp marked this pull request as draft September 28, 2022 08:22
@BDisp BDisp marked this pull request as ready for review September 28, 2022 09:35
@tig tig changed the title Fixes #2069. KeyDown and KeyUp events must run before OnKeyDown and OnKeyUp. Fixes #2069. Enable KeyDown and KeyUp events to be canceled (like KeyPress) Sep 29, 2022
@tig
Copy link
Collaborator

tig commented Sep 29, 2022

@BDisp we got a merge conflict. Can you fix please?

@BDisp BDisp force-pushed the view-keydown-keyup-fix branch from ae252c9 to eaaa636 Compare September 29, 2022 18:11
@BDisp
Copy link
Collaborator Author

BDisp commented Sep 29, 2022

@BDisp we got a merge conflict. Can you fix please?

Done @tig.

@tig tig merged commit df72859 into gui-cs:develop Sep 29, 2022
@BDisp BDisp deleted the view-keydown-keyup-fix branch September 29, 2022 18:20
This was referenced Nov 4, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tig tig tig approved these changes

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable KeyDown and KeyUp events to be canceled (like KeyPress)

2 participants

@BDisp @tig