Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1989. ListView: Ensures SelectedItem visibility on MoveDown and MoveUp. #1990

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Sep 4, 2022

Fixes #1989 - After scrolling down or up, the selected isn't visible and this is a normal behavior. But if the cursor down and cursor up are pressed the selected item must be visible to be more easier to find it.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #1989. Ensures SelectedItem visibility on MoveDown and MoveUp. Fixes #1989. ListView: Ensures SelectedItem visibility on MoveDown and MoveUp. Sep 5, 2022
@tig tig merged commit 3866e65 into gui-cs:develop Sep 5, 2022
@BDisp BDisp deleted the listview-visibility-selecteditem-fix branch September 5, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListView doesn't ensure SelectedItem visibility on MoveDown and MoveUp
2 participants