Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1773. Base color scheme for ListView hard to read #1937

Merged
merged 7 commits into from
Aug 4, 2022
Merged

Fixes #1773. Base color scheme for ListView hard to read #1937

merged 7 commits into from
Aug 4, 2022

Conversation

tig
Copy link
Collaborator

@tig tig commented Aug 4, 2022

Fixes #1773

Simple fix: Changes HotNormal to use Cyan instead of DarkCyan. Not a dramatic change, but should improve readability.

Before:
image

After:
image

@tig tig requested a review from migueldeicaza as a code owner August 4, 2022 01:56
@tig tig merged commit 3257bd8 into gui-cs:develop Aug 4, 2022
@BDisp
Copy link
Collaborator

BDisp commented Aug 4, 2022

I think this also should be done on all drivers to be consistent.

@BDisp BDisp mentioned this pull request Aug 4, 2022
Closed
@tig
Copy link
Collaborator Author

tig commented Aug 4, 2022

I think this also should be done on all drivers to be consistent.

You're right. Oops. Thanks for noticing.

@tig tig deleted the fix_1773_Base_ColorScheme branch August 4, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default color scheme can be hard to read for some users
2 participants
@tig @BDisp