Skip to content

Used package is not listed as a dependency #8

Description

@mzyil

Hi, this package depends on async v1.5.x (so does botbuilder v3). However that async package is not listed in the dependencies and it causes problems with the other package which depend on different versions of the async package. npm installs them to the related package's own folder, forcing this package to use the old version.

I will open a PR related to this and add the async version that the required botbuilder version requires.

People with the wrong version would get:

... async.forEachOfSeries is not a function
    at TestConnector.send (... /node_modules/botbuilder-unit/src/TestConnector.js:36:11)

TestConnector.js requires async.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions