add embeddings reusability in score fct + update readme accordingly #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudgud96
approved these changes
Aug 7, 2023
|
@ThibaultCastells Thanks for your help! It is much more handy in this case. Agree that this makes embeddings more easily reusable. Will proceed to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement suggestion related to #13
This code update allows to easily reuse the embeddings.
The code is not 100% backward compatible as it does not use the
store_embdsanymore, but I made it such that people who were using the default value forstore_embdswon't see any difference.I also updated the demo in the README to show how to use this update.