Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose AGH dashboard #12

Merged
merged 17 commits into from
Apr 9, 2023
Merged

Expose AGH dashboard #12

merged 17 commits into from
Apr 9, 2023

Conversation

llamaonduty
Copy link
Member

This PR does the following:

  • Exposes AGH dashboard
  • Introduces JWT auth to protect the AGH dashboard as well as other API endpoints
  • Persists changes made on the AGH dashboard by mounting PV to the AGH pod
  • A bunch of renames to AdGuardHome.

This fixes: #7

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 9, 2023
View reviewed changes
internal/web/proxy.go
func trimPathPrefix(s, prefix string) string {
r := strings.TrimPrefix(s, prefix)
fmt.Println(r)
if !strings.HasPrefix(r, "/") {

Check warning

Code scanning / CodeQL

Bad redirect check

This is a check that [this value](1), which flows into a [redirect](2), has a leading slash, but not that it does not have '/' or '\' in its second position.
@llamaonduty llamaonduty merged commit 13ced21 into main Apr 9, 2023
@llamaonduty llamaonduty deleted the llamaonduty/adguard_pvc branch April 9, 2023 04:51
This was referenced Apr 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: expose the AGH dashboard
1 participant
@llamaonduty