Skip to content

Conversation

@shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Jul 19, 2024

What does this PR do?

Fixes parts of #4213

TODO

  • Rewrite some parts of Zerologon
  • Add links to reference pages at the bottom
  • Cross-check mitigations in each plugin's manifest file with the ones in the docs Decide an order for SNMP. The manifest's and the documentation's suggestions are slightly different. --- UPDATE: guardicode/snmp-exploiter#1

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (0d8a3e3) to head (a045c02).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4247      +/-   ##
===========================================
- Coverage    77.07%   76.97%   -0.11%     
===========================================
  Files          442      430      -12     
  Lines        14135    13599     -536     
  Branches        18       18              
===========================================
- Hits         10895    10468     -427     
+ Misses        3240     3131     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyamalviya shreyamalviya force-pushed the 4213-docs-exploiters-feature-pages_vuln branch from 95bf959 to 309ece7 Compare July 19, 2024 12:06
@shreyamalviya shreyamalviya marked this pull request as ready for review July 19, 2024 12:09
@shreyamalviya shreyamalviya force-pushed the 4213-docs-exploiters-feature-pages_vuln branch 2 times, most recently from 051d75c to b682d6f Compare July 22, 2024 11:31
@mssalvatore mssalvatore force-pushed the 4213-docs-exploiters-feature-pages_vuln branch from 0ac7850 to 503c5c9 Compare July 22, 2024 18:09
@mssalvatore mssalvatore force-pushed the 4213-docs-exploiters-feature-pages_vuln branch from d7f24e1 to 7b0c18f Compare July 23, 2024 16:23
@mssalvatore mssalvatore merged commit e723cd6 into develop Jul 23, 2024
@mssalvatore mssalvatore deleted the 4213-docs-exploiters-feature-pages_vuln branch July 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants