Show detected custom bridge type as a chip #1461
Open
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is a nice idea. Will review asap. Thanks! |
meenbeese
force-pushed
the
bridges-chip
branch
2 times, most recently
from
fdf1c16 to
ee46c53
Compare
Contributor
Author
|
Rebased and fixed the implementation for #1443. |
Contributor
|
Perhaps unrelated to what this PR wants to achieve, but I've also noticed that Orbot's main view (with Orbi) displays the bridge type being used when in VPN mode, but not when in power user mode. |
meenbeese
force-pushed
the
bridges-chip
branch
from
ee46c53 to
b5ff27b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a UX change that can help beginner users by informing them of the bridge type they entered. Obviously the phrase I used is for debugging purposes. Also, the UI can potentially be improved for this bottom sheet but I don't have any great ideas yet. Open to suggestions.
Tested on Pixel 8 API 35.