Skip to content

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

Updates:

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "org.scalatest", artifactId = "scalatest" },
  { groupId = "software.amazon.awssdk", artifactId = "ssm" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "@monthly" },
    dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
  },
  {
    pullRequests = { frequency = "@monthly" },
    dependency = { groupId = "software.amazon.awssdk", artifactId = "ssm" }
  }
]

labels: test-library-update, library-update, early-semver-patch, semver-spec-patch, commit-count:n:2

rtyley added a commit that referenced this pull request Jan 12, 2023
Based off #381, which had the title 'Non-AWS dependency updates' but included `software.amazon.awssdk:ssm`, when we do pullRequests.grouping filter that specifies group, we need to use the full group name, not just the start of it.
@rtyley
Copy link
Member

rtyley commented Jan 12, 2023

Given that this PR has the title 'Non-AWS dependency updates' but included software.amazon.awssdk:ssm, it seems that when we do a pullRequests.grouping filter that specifies group, we need to use the full group name, not just the start of it - this is the old config we had (note "group" = "software.amazon"):

pullRequests.grouping = [
{ name = "aws", "title" = "AWS dependency updates", "filter" = [{"group" = "software.amazon"}, {"group" = "com.amazonaws"}] },
{ name = "non_aws", "title" = "Non-AWS dependency updates", "filter" = [{"group" = "*"}] }

Fixed in this repo with c1cbc2a.

@rtyley rtyley merged commit 3cdec3c into main Jan 12, 2023
@rtyley rtyley mentioned this pull request Jan 12, 2023
rtyley added a commit to guardian/support-frontend that referenced this pull request Jan 12, 2023
Not sure if this will fully resolve the problems with Scala Steward not respecting the `pullRequests.grouping` setting, but from testing on another repo (https://github.com/guardian/play-secret-rotation), I did find that the full group name must be specified (so `software.amazon.awssdk`, not `software.amazon`).

* guardian/play-secret-rotation#381 - incorrectly grouped, Scala Steward conf was `"group" = "software.amazon"`
* guardian/play-secret-rotation#382 - correctly grouped, Scala Steward conf was `"group" = "software.amazon.awssdk"`

See also the discussion in scala-steward-org/scala-steward#2714 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant