Image cache purger - #4954
Open
lindseydew wants to merge 45 commits into
Open
Image cache purger#4954lindseydew wants to merge 45 commits into
lindseydew wants to merge 45 commits into
Conversation
… ld/image-cache-purger
… ld/image-cache-purger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This creates a lambda service which listens to s3 notifications when images are deleted from the
[media-origin.test.dev-guim.co.uk](https://eu-west-1.console.aws.amazon.com/s3/buckets/media-origin.test.dev-guim.co.uk?region=eu-west-1)bucketIt then calls the fastly cache purger for the media.guim and i.guim domains.
How should a reviewer test this change?
To test:
Crop an image in grid:
https://media.test.dev-gutools.co.uk/images/eb70ab23c51544cdc58c51306928a3e69df8045d?crop=0_0_4860_3240
Check the image at
https://media.guimcode.co.uk/eb70ab23c51544cdc58c51306928a3e69df8045d/0_0_4860_3240/2000.jpg
https://i.guimcode.co.uk/img/media/eb70ab23c51544cdc58c51306928a3e69df8045d/0_0_4860_3240/2000.jpg?width=480&dpr=1&s=none&crop=none
Then, delete the crops.
Then check the urls again. Should see a 403.
How can success be measured?
Steps for deploying to PROD
Who should look at this?
Tested? Documented?