Conversation
ob6160
approved these changes
Jan 5, 2022
akash1810
reviewed
Jan 5, 2022
98b2a4c to
6c36175
Compare
dominickendrick
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Switches CI from TeamCity to GitHub Actions (with the use of https://github.com/guardian/actions-assume-aws-role).
There are a few benefits to using GHA individually:
nodedocker versionsyarnIn RiffRaff the build numbers will count up from 5000 now, as the teamcity builds are currently in the 4000s.
To help perform the migration, I used migration doc and example prs from Prism and tag-janitor.
How to test
identity:identity-gatewayshould appear as a deployable project in Riff-Raff. It should be successfully deployed to CODE.https://riffraff.gutools.co.uk/deployment/view/efa79594-2d2f-4b0d-8339-3e591bf3873f
Pre merge
Post merge
mainto deploy toCODE/PRODgoing forward