-
Notifications
You must be signed in to change notification settings - Fork 566
Support new media atom fields #28326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+64
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
simonbyford
commented
Oct 29, 2025
simonbyford
commented
Oct 29, 2025
Contributor
simonbyford
commented
Nov 13, 2025
Co-Authored-By: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
020494d to
eb7fc86
Compare
ioannakok
approved these changes
Nov 21, 2025
Contributor
ioannakok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Seen on ADMIN-PROD (merged by @simonbyford 10 minutes and 1 second ago)
|
|
Seen on FRONTS-PROD (merged by @simonbyford 12 minutes and 12 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Jonathon Herbert jonathon.herbert@guardian.co.uk
What does this change?
Adds frontend support for the new media atom fields added here: guardian/content-atom#184
These fields have been available in the scala client since v39.0.0.
This will allow us to start using them in DCR.
Screenshots
Run frontend locally and visit:
http://localhost:9000/world/2025/nov/19/moscow-passes-laws-to-boost-defences-against-ukrainian-strikes.json?dcr=true
Note the new fields
aspectRatio,dimensions, andvideoPlayerFormatare all coming through:Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)Related PRs