Reduce blur height of blur on vertical feature cards#15245
Open
Reduce blur height of blur on vertical feature cards#15245
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
force-pushed
the
ab/blur-podcast
branch
from
7d5ab2c to
f05fcc2
Compare
abeddow91
added
maintenance
github-actions
bot
removed
the
run_chromatic
abeddow91
force-pushed
the
ab/blur-podcast
branch
from
ac61eff to
d95da09
Compare
abeddow91
force-pushed
the
ab/blur-podcast
branch
from
d95da09 to
2c2ed1d
Compare
domlander
reviewed
Feb 2, 2026
| padding: ${space[9]}px ${space[2]}px ${space[2]}px; | ||
|
|
||
| /* | ||
| * Ensure the waveform is behind the other elements, e.g. headline, pill. |
Contributor
There was a problem hiding this comment.
The indentation here is a bit off
| ); | ||
| `; | ||
|
|
||
| const contentOverlayStyle = css` |
Contributor
There was a problem hiding this comment.
Suggested change
| const contentOverlayStyle = css` | |
| const contentOverlayStyles = css` |
| (isImmersive ? ( | ||
| <Hide from="tablet"> | ||
| {renderPodcastImage( | ||
| <div css={contentOverlayStyle}> |
Contributor
There was a problem hiding this comment.
Why is this extra div needed?
| left: 0; | ||
| z-index: 0; | ||
| height: 64px; | ||
| height: 40px; |
Contributor
There was a problem hiding this comment.
Is it expected that immersive podcasts will also now use the shorter waveform?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the design of feature cards
To account for this reduction in padding blur, the blur has been moved into its own div so that it does not apply to the content itself.
Why?
Design would like to obscure less of the image in order to better serve video in these cards.
Screenshots