Skip to content

Conversation

@Jakeii
Copy link
Member

@Jakeii Jakeii commented Dec 1, 2025

What does this change?

add ab-testing directory to paths-ignore for the DCR CICD workflow, except for abTests.ts

Why?

It doesn't need to run on the ab-testing projects.

it does for abTests.ts as it's imported into Metrics.importable.tsx to work out which tests to bypass metrics sampling for.

@Jakeii Jakeii requested a review from a team as a code owner December 1, 2025 17:34
@Jakeii Jakeii changed the title ignore ab-testing**/* in DCR CICD ignore ab-testing/**/* in DCR CICD Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Dec 3, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Dec 3, 2025
@Jakeii Jakeii merged commit 9ced453 into main Dec 3, 2025
30 checks passed
@Jakeii Jakeii deleted the jlk/ignore-ab-testing-dcr-cicd branch December 3, 2025 17:22
@gu-prout
Copy link

gu-prout bot commented Dec 3, 2025

Seen on PROD (merged by @Jakeii 7 minutes and 54 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants