Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import type { Handler } from 'express';
import { validateAsFEArticle } from '../../model/validate';
import { logger } from './logging';

const SAFE_AB_VALUE = /^[a-zA-Z0-9_-]+$/;
const MAX_LENGTH = 100;

export const getABTestsFromQueryParams: Handler = async (req, res, next) => {
try {
const frontendData = validateAsFEArticle(req.body);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work for other page types, Fronts etc.

const { config } = frontendData;
const queryParamsAb = req.query;
const filteredQuery: Record<string, string> = {};

for (const [key, value] of Object.entries(queryParamsAb)) {
if (!key.startsWith('ab-') || typeof value !== 'string') {
continue;
}

const testId = key.replace(/^ab-/, '');

if (
testId.length > 0 &&
testId.length <= MAX_LENGTH &&
value.length > 0 &&
value.length <= MAX_LENGTH &&
SAFE_AB_VALUE.test(testId) &&
SAFE_AB_VALUE.test(value)
) {
filteredQuery[testId] = value;
} else {
logger.warn(
`Rejected invalid AB test parameter: ${key}=${value}`,
);
}
}

config.serverSideABTests = {
...config.serverSideABTests,
...filteredQuery,
};
req.body = frontendData;
} catch (error) {
return next();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should log the error here, to help resolve issues if people don't format their params quite right!

}
next();
};
2 changes: 2 additions & 0 deletions dotcom-rendering/src/server/server.dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
handleFootballMatchPage,
handleFootballTablesPage,
} from './handler.sportDataPage.web';
import { getABTestsFromQueryParams } from './lib/get-abtests-from-query-params';
import { getContentFromURLMiddleware } from './lib/get-content-from-url';

/** article URLs contain a part that looks like “2022/nov/25” */
Expand Down Expand Up @@ -90,6 +91,7 @@ const renderer = Router();
// populates req.body with the content data from a production
// URL if req.params.url is present
renderer.use(getContentFromURLMiddleware);
renderer.use(getABTestsFromQueryParams);
renderer.get('/Article/*url', handleArticle);
renderer.get('/Interactive/*url', handleInteractive);
renderer.get('/Blocks/*url', handleBlocks);
Expand Down
Loading