Add an opt in 0% test for enabling CORS on looping videos #14795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
force-pushed
the
ab/cors-loop-ab-test
branch
from
a7af839 to
fb2d933
Compare
domlander
approved these changes
Nov 5, 2025
|
Seen on PROD (merged by @abeddow91 7 minutes and 52 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We need to enable CORS on looping videos so that we can work a side-car VTT file. This PR introduces the crossOrigin: anonymous header behind a 0% opt in flag so that we can test how this interacts with the fastly cache. It has only been drilled through container and container card sizes that support looping video.
Why?
We released this change into the wild and found some users were receiving CORS errors. We would like to debug and fix this before we re-release this change.
Screenshots