set the unselected choice card text colour straight #14770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
juabara
changed the title
sookburt
reviewed
Oct 29, 2025
| color: ${isSelected | ||
| ? choiceCardSettings?.buttonSelectTextColour ?? 'inherit' | ||
| : choiceCardSettings?.buttonTextColour ?? 'inherit'}; | ||
| s { |
Contributor
There was a problem hiding this comment.
What does the s stand for on this line?
Contributor
Author
There was a problem hiding this comment.
Before the buttonTextColour was setting the colour to the label, but the inner css was overring the text colour, so I moved the label override to the label div and applied the buttonTextColour to it. The s was already there, so I prefered to keep it.
Member
There was a problem hiding this comment.
it's applying style to strikethrough tags (<s>).
This is used when a promo is present and it displays the old price in <s> tags
github-actions
bot
removed
the
run_chromatic
tomrf1
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Set unselected choice card colour.