Skip to content

Delete AMP #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arelra merged 11 commits into from
Sep 23, 2025
Merged

Delete AMP #14534

arelra merged 11 commits into from
Sep 23, 2025

Conversation

@arelra
Copy link
Member

@arelra arelra commented Sep 19, 2025 •
edited
Loading

@arelra arelra added the run_chromatic Runs chromatic when label is applied label Sep 19, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025 •
edited
Loading

Deploy build 21031 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 19, 2025
@arelra arelra linked an issue Sep 22, 2025 that may be closed by this pull request
Delete AMP #14537
Open
@arelra arelra marked this pull request as ready for review September 22, 2025 10:25
@arelra arelra requested a review from a team as a code owner September 22, 2025 10:25
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

ioannakok
ioannakok approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@ioannakok ioannakok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how thorough we can be but I can still find references to AMP in the codebase.

Also, should the decision to stop supporting AMP be documented? Has it already been somewhere? https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/docs/architecture/011-amp.md

Approving - these are just some non-blocking thoughts

@arelra @ioannakok
Remove more AMP references
ca039db 
Co-authored-by: Ioanna Kokkini <ioannakok@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Deploy build 45267 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@arelra
Copy link
Member Author

arelra commented Sep 23, 2025

Not sure how thorough we can be but I can still find references to AMP in the codebase.

Great spot thanks! I've updated.

I think it's going to be a case of whack-a-mole to find all the 'live' references to AMP

@arelra
Copy link
Member Author

arelra commented Sep 23, 2025

Also, should the decision to stop supporting AMP be documented? Has it already been somewhere? https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/docs/architecture/011-amp.md

Very good point. I will create an ADR for it.

@arelra arelra removed a link to an issue Sep 23, 2025
Delete AMP #14537
Open
@arelra arelra linked an issue Sep 23, 2025 that may be closed by this pull request
Delete AMP - DCAR #14550
Closed
@arelra
Copy link
Member Author

arelra commented Sep 23, 2025

ADR here:
https://github.com/guardian/dotcom-rendering/blob/44723c8da0b825c2cb8b53540a34c29bf7f5695f/dotcom-rendering/docs/architecture/030-amp-removal.md

@arelra arelra added the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@arelra arelra merged commit 22493b7 into main Sep 23, 2025
27 checks passed
@arelra arelra deleted the ravi/delete-amp branch September 23, 2025 15:12
@gu-prout
Copy link

gu-prout bot commented Sep 23, 2025

Seen on PROD (merged by @arelra 6 minutes and 47 seconds ago) Please check your changes!

@JamieB-gu JamieB-gu mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioannakok ioannakok ioannakok approved these changes

Assignees

No one assigned

Labels

dotcom-rendering Seen-on-PROD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete AMP - DCAR

3 participants

@arelra @ioannakok