Skip to content

Remove Crossword component from dev kitchen #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

jamesmockett
Copy link
Contributor

What are you changing?

Removes Crossword component from Source Development Kitchen.

Why?

This was a proof of concept component which has now been superseded by the standalone @guardian/react-crossword package. The existence of two Crossword components was causing confusion for contributors.

@jamesmockett jamesmockett requested review from a team as code owners April 7, 2025 16:24
Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: 9fcf696

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Apr 7, 2025
@jamesmockett jamesmockett added the run_chromatic Runs chromatic when label is applied label Apr 7, 2025
@jamesmockett jamesmockett requested review from a team as code owners April 7, 2025 16:26
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔠 🧹 👍

@jamesmockett jamesmockett merged commit f360ebe into main Apr 8, 2025
21 checks passed
@jamesmockett jamesmockett deleted the jm/remove-dev-kitchen-crossword branch April 8, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants