Skip to content

Remove Prebid vendor #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Remove Prebid vendor #2041

merged 2 commits into from
May 19, 2025

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Mar 27, 2025 •
edited
Loading

What are you changing?

  • Removes Prebid and Prebid custom vendors

Why?

  • We check consent for each Prebid vendor individually[1] and don't actually send any data to Prebid itself (as we don't use Prebid Server), and so we can remove it from our vendor list

[1] Relevant PRs:
* guardian/commercial#1797
* guardian/commercial#1850
* guardian/commercial#1800

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 583e54f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/libs labels Mar 27, 2025
@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from 5776c61 to f2c5237 Compare March 27, 2025 11:51
@cemms1 cemms1 added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Mar 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from bb8e67f to bd1ada9 Compare March 27, 2025 18:36
@github-actions GitHub Actions
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@cemms1 cemms1 removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label Mar 27, 2025
@cemms1 cemms1 marked this pull request as ready for review March 27, 2025 18:56
@cemms1 cemms1 requested review from a team as code owners March 27, 2025 18:56
@cemms1 cemms1 marked this pull request as draft March 31, 2025 15:48
@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from bd1ada9 to e5e032c Compare April 29, 2025 16:45
@cemms1 cemms1 added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2025

Note

The following canaries were published to NPM:

🐥

This was referenced May 1, 2025
Merged
Merged
@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from e5e032c to e2a10be Compare May 2, 2025 16:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Note

The following canaries were published to NPM:

🐥

@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from e2a10be to e2aaeb2 Compare May 9, 2025 08:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Note

The following canaries were published to NPM:

🐥

@cemms1 cemms1 removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 9, 2025
@cemms1 cemms1 marked this pull request as ready for review May 9, 2025 10:19
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label May 9, 2025
@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from e2aaeb2 to de74d9a Compare May 9, 2025 15:03
@cemms1 cemms1 force-pushed the cemms1/remove-prebid-vendor branch from de74d9a to 583e54f Compare May 19, 2025 10:05
@cemms1 cemms1 merged commit 43c7f98 into main May 19, 2025
21 checks passed
@cemms1 cemms1 deleted the cemms1/remove-prebid-vendor branch May 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-hardy i-hardy i-hardy approved these changes

@akinsola-guardian akinsola-guardian akinsola-guardian approved these changes

Assignees
No one assigned
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemms1 @i-hardy @akinsola-guardian