Skip to content
This repository was archived by the owner on Sep 1, 2021. It is now read-only.

Conversation

@marjisound
Copy link
Contributor

@marjisound marjisound commented Aug 11, 2021

Why are you doing this?

This PR updates node version from 12.13 to 14.16 and also updates github actions setup-node step to use nvmrc

Changes

  • updates node version from 12.13 to 14.16
  • use guardian/actions-setup-node instead of setup-node in github actions in order to install node based on nvmrc
  • Update TeamCity steps to use nvmrc as the node version (Add CI bash script for TeamCity Build #1448)

TODO:

  • Update AMI node version

@marjisound marjisound changed the title update nvmrc node version and update actions to use nvmrc update node version to 14.16 Aug 11, 2021
@JamieB-gu
Copy link
Contributor

  • updates github actions setup-node step to use nvmrc

How does setup-node know to use .nvmrc?

@marjisound
Copy link
Contributor Author

  • updates github actions setup-node step to use nvmrc

How does setup-node know to use .nvmrc?

Thanks @JamieB-gu for spotting this. I updated the action library to guardian/actions-setup-node. The original action actions/setup-node won't use nvmrc for node version and it recommends that we give node version to it via its node-version parameter while guardian/actions-setup-node would use nvmrc node version if it exists.

@marjisound marjisound merged commit 5a27151 into main Aug 16, 2021
@marjisound marjisound deleted the migrate-node-version branch August 16, 2021 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants