Skip to content

Conversation

helio-frota
Copy link
Collaborator

@helio-frota helio-frota commented Sep 19, 2025

Signed-off-by: Helio Frota 00hf11@gmail.com

  • Also adds instrument macro to delete_sbom function

Summary by Sourcery

Silence Tempo warning by increasing the trace size limit in its config and add tracing instrumentation to the delete_sbom method

Enhancements:

  • Set max_bytes_per_trace to 50000000 in Tempo compose configuration
  • Add #[instrument] macro to delete_sbom method for improved tracing and error logging

Deployment:

  • Update etc/deploy/compose/config-tempo.yaml to configure max_bytes_per_trace

Signed-off-by: Helio Frota <00hf11@gmail.com>

* Also adds instrument macro to delete_sbom function
Copy link
Contributor

sourcery-ai bot commented Sep 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR silences Tempo warning messages by setting a maximum trace size in the compose configuration and adds tracing instrumentation to the SBOM service’s delete_sbom method for improved log handling.

File-Level Changes

Change Details Files
Suppress tempo warning by configuring max trace size
  • Added max_bytes_per_trace under overrides with value 50000000
etc/deploy/compose/config-tempo.yaml
Enhance delete_sbom with tracing instrumentation
  • Applied #[instrument(skip(self, connection), err(level=tracing::Level::INFO))] to delete_sbom method
modules/fundamental/src/sbom/service/sbom.rs

Possibly linked issues

  • #0: The PR silences tempo warnings by increasing max trace size and adds an instrument macro to delete_sbom, directly addressing the issue's concerns.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota helio-frota linked an issue Sep 19, 2025 that may be closed by this pull request
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.91%. Comparing base (bc02c2b) to head (4161622).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   67.64%   67.91%   +0.26%     
==========================================
  Files         354      354              
  Lines       19729    19714      -15     
  Branches    19729    19714      -15     
==========================================
+ Hits        13345    13388      +43     
+ Misses       5609     5550      -59     
- Partials      775      776       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No sense warning from tempo related to large traces
1 participant