Skip to content

Conversation

dejanb
Copy link
Contributor

@dejanb dejanb commented Aug 18, 2025

Summary by Sourcery

Fix test for the analysis latest endpoint to ensure it checks for the new expected total and verifies that the latest SBOMs from all products are included.

Bug Fixes:

  • Update expected total from 2 to 3 in the latest_filters test
  • Add assertions to confirm the presence of quarkus-camel-bom and quarkus-cxf-bom in the returned items

Copy link
Contributor

sourcery-ai bot commented Aug 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Expanded the existing test for the latest analysis endpoint to account for additional SBOM products by updating the expected total count and explicitly verifying the presence of specific product names in the response.

File-Level Changes

Change Details Files
Adjust expected total and validate presence of new products
  • Updated the assertion for response["total"] from 2 to 3
  • Collected product_name values from response items into a HashSet
  • Added assertions to ensure "quarkus-camel-bom" and "quarkus-cxf-bom" are included
modules/analysis/src/endpoints/tests/latest_filters.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dejanb dejanb requested a review from ctron August 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant