-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClearlyDefined to e2e test #2168
Conversation
39f1a5a
to
0dab620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just needs a small tweak to the query and it will be all set! Thank You!
a2d4fdc
to
738408a
Compare
Hey @robert-cronin, a fix for the flaky e2e tests was recently merged in #2189. If you rebase your branch, the end-to-end tests should now work correctly. |
738408a
to
49e8e18
Compare
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
49e8e18
to
4571162
Compare
Thanks @nathannaveen, the e2e tests are working now! however there now appears to be an issue with the unit and integration tests. I am not entirely sure what is going on, but my best guess is that it is just some flakiness, perhaps a temporary failure to resolve the CD url? this tcp lookup error occurred in both suites:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you
Add ClearlyDefined to e2e test
Fixes #2142
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run