Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClearlyDefined to e2e test #2168

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented Oct 7, 2024

Add ClearlyDefined to e2e test

Fixes #2142

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just needs a small tweak to the query and it will be all set! Thank You!

demo/graphql/queries.gql Show resolved Hide resolved
@nathannaveen
Copy link
Contributor

Hey @robert-cronin, a fix for the flaky e2e tests was recently merged in #2189. If you rebase your branch, the end-to-end tests should now work correctly.

Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
@robert-cronin
Copy link
Contributor Author

robert-cronin commented Oct 14, 2024

Hey @robert-cronin, a fix for the flaky e2e tests was recently merged in #2189. If you rebase your branch, the end-to-end tests should now work correctly.

Thanks @nathannaveen, the e2e tests are working now! however there now appears to be an issue with the unit and integration tests. I am not entirely sure what is going on, but my best guess is that it is just some flakiness, perhaps a temporary failure to resolve the CD url? this tcp lookup error occurred in both suites:

2024-10-14T01:59:10.7711001Z --- FAIL: TestClearlyDefined (14.28s)
2024-10-14T01:59:10.7712449Z     --- FAIL: TestClearlyDefined/query_and_generate_attestation_from_clearly_defined (14.09s)
2024-10-14T01:59:10.7719373Z         clearlydefined_test.go:122: g.RetrieveArtifacts() error = could not generate document from Clearly Defined results: generateDefinitions failed with error: failed get package definition from clearly defined with error: clearly defined POST request failed with error: error making POST request: Post "https://api.clearlydefined.io/definitions": dial tcp: lookup api.clearlydefined.io on 127.0.0.53:53: read udp 127.0.0.1:44577->127.0.0.53:53: i/o timeout, wantErr false
2024-10-14T01:59:10.7723400Z FAIL
2024-10-14T01:59:10.7724080Z FAIL	github.com/guacsec/guac/pkg/certifier/clearlydefined	15.487s

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@kodiakhq kodiakhq bot merged commit 7ee10f0 into guacsec:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add ClearlyDefined to e2e test
5 participants