Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve on ingestion license check #2152

Merged
merged 2 commits into from
Sep 26, 2024
Merged

improve on ingestion license check #2152

merged 2 commits into from
Sep 26, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Sep 26, 2024

Description of the PR

  • remove unneeded batching (as the rate limit was not being hit)
  • do not query for source license on ingestion (only enabled when the certifier runs)

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit 6ea218b into main Sep 26, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the update-on-ingest-license branch September 26, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants