This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Return a string of any lifetime from Quark::to_string() #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying it as 'static is very specific and instead we can let the caller chose any lifetime they want here.
|
A static reference can be reborrowed into a reference with any lifetime. Why is this needed? |
|
Oh, then we have no choice 😭 |
|
👍 |
gstreamer-github
pushed a commit
to sdroege/gstreamer-rs
that referenced
this pull request
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying it as 'static is very specific and instead we can let the
caller chose any lifetime they want here.
CC @GuillaumeGomez @EPashkin