Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blur from GtkPopupMenu #76

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

KevMCarp
Copy link
Contributor

Fixes #75

I'm not sure the original reason for adding blur so this may be the wrong approach, however removing it fixes the issues with dark mode, while remaining correct in light mode.

Comparison screenshots below.

Before
before-light
before-dark

After
after-light
after-dark

Gnome Workbench
vlcsnap-2022-08-29-15h20m54s326

Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think It was just trial and error to add blur radius but we forgot to test it with the original design.

@prateekmedia prateekmedia merged commit 18e8914 into gtk-flutter:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PopupMenu blurry in dark mode
2 participants