Use very_good_analysis linting rules
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekmedia
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for this large PR touching almost everything in the codebase but as I suggested #51 (comment) this is a needed step to improve consistency and code quality of the package, making sure that it stays high in the future.
Most are minor info messages or warnings but others are considered errors and may even have an impact on compile size and runtime performance (e.g. avoid_dynamic_calls)
I don't know enough about this package yet to address all of them but this is a good start, most of what's left now it's just documentation of public members which will be best done once this package reaches API stability.
I know it's hard to review a big mix of things in a single PR like this but I tried to minimize review burden by making one commit per linting rule solved.
I look forward for your feedback :)