Skip to content

project and reflection requires square length #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

project and reflection requires square length #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b765e87
fix equation on project and reflection
newpolaris Feb 3, 2021
26b3c81
small bugs on quaternion comparision
newpolaris Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions AllChapters/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON &&
fabsf(left.y - right.y) <= QUAT_EPSILON &&
fabsf(left.z - right.z) <= QUAT_EPSILON &&
fabsf(left.w - left.w) <= QUAT_EPSILON);
fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
Expand All @@ -101,9 +101,9 @@ bool operator!=(const quat& a, const quat& b) {

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON &&
fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON &&
fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions AllChapters/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -87,7 +87,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
4 changes: 2 additions & 2 deletions Chapter02/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
4 changes: 2 additions & 2 deletions Chapter03/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter04/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter04/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter05/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter05/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter06/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter06/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter06/Sample01/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter06/Sample01/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter07/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter07/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter08/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter08/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter08/Sample01/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter08/Sample01/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter09/Sample00/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
4 changes: 2 additions & 2 deletions Chapter09/Sample00/Code/vec3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ float angle(const vec3& l, const vec3& r) {
}

vec3 project(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand All @@ -88,7 +88,7 @@ vec3 reject(const vec3& a, const vec3& b) {
}

vec3 reflect(const vec3& a, const vec3& b) {
float magBSq = len(b);
float magBSq = lenSq(b);
if (magBSq < VEC3_EPSILON) {
return vec3();
}
Expand Down
6 changes: 3 additions & 3 deletions Chapter09/Sample01/Code/quat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,16 @@ quat operator-(const quat& q) {
}

bool operator==(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON);
}

bool operator!=(const quat& a, const quat& b) {
return !(a == b);
}

bool sameOrientation(const quat& left, const quat& right) {
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - left.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + left.w) <= QUAT_EPSILON);
return (fabsf(left.x - right.x) <= QUAT_EPSILON && fabsf(left.y - right.y) <= QUAT_EPSILON && fabsf(left.z - right.z) <= QUAT_EPSILON && fabsf(left.w - right.w) <= QUAT_EPSILON)
|| (fabsf(left.x + right.x) <= QUAT_EPSILON && fabsf(left.y + right.y) <= QUAT_EPSILON && fabsf(left.z + right.z) <= QUAT_EPSILON && fabsf(left.w + right.w) <= QUAT_EPSILON);
}

float dot(const quat& a, const quat& b) {
Expand Down
Loading