Skip to content

Issue 176 - Promise change listener being garbage collected #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2020
Merged

Issue 176 - Promise change listener being garbage collected #200

merged 2 commits into from
May 5, 2020

Conversation

neilcsmith-net
Copy link
Member

Fix #176 where Promise change listener can be garbage collected. Keep GstCallback, which in turn wraps user function, in a field.

@neilcsmith-net
Update PromiseTest and add test for issue 176.
cc761ea
@neilcsmith-net
Fix issue 176 - Promise change listener being garbage collected.
cce4cf5 
Keep GstCallback in field reference (which in turn holds reference to user supplied PROMISE_CHANGE listener). Both must live as long as Promise itself.
@neilcsmith-net neilcsmith-net added this to the 1.2 milestone Apr 17, 2020
@neilcsmith-net neilcsmith-net mentioned this pull request Apr 17, 2020
Closed
@neilcsmith-net neilcsmith-net merged commit 026d16b into gstreamer-java:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Change func got collected before triggering
1 participant
@neilcsmith-net