Emit error in logs if keytab files can't be opened #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| apr_strerror(rc, err, sizeof(err)); | ||
| ap_log_error(APLOG_MARK, APLOG_ERR, 0, parms->server, | ||
| "Cannot open %s file %s: %s", key, value, err); | ||
| } else { |
There was a problem hiding this comment.
Shouldn't this error cause a function exit, like we do above? (That would also let you remove this else-block.)
There was a problem hiding this comment.
no
I want the thing not to crash the apache server
it is possible during deployment people add a client _ketab later
I just want admins to see the error if something doesn't work, not a hard fail
This will give a useful warning to admins when config point to missing files. Signed-off-by: Simo Sorce <simo@redhat.com>
frozencemetery
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give a useful warning to admins when config point to missing
files.
Fixes #228