Fix truncation on comparison in name attr maps #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, apologies for the delay in testing. Yes, this does appear to fix the problem, thank you! 👍 |
Contributor
Author
|
@frozencemetery PTAL |
The check to match a mapped name to a named attribute inadvertently considered only the length of one of the strings. This would cause incorrect prefix matches. Signed-off-by: Simo Sorce <simo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check to match a mapped name to a named attribute inadvertently
considered only the length of one of the strings.
This would cause incorrect prefix matches.
Fixes #173