Fix missing FontAwesome special characters#7
Open
csidirop wants to merge 1 commit intogsoules:masterfrom
Open
Conversation
Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
Author
|
Hi @gsoules hope you are well. Are you still working on this plugin? |
Owner
|
I am not actively working on the plugin, but thank you for bringing this to my attention. I'm not seeing the issue on any of my sites. I'm wondering why the CSS behaves badly on some installations, but not others. Do you know? |
Author
|
To be honest I don't really know (anymore). I can look into it as soon I have some spare time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
The current implementation does not load the arrow icons correctly, as you can see here:

According to these instructions, the CSS styling must be corrected. With those corrections the icons are shown again:

There is another occurrence wich calls
"FontAwesome":AvantSearch/views/public/css/avantsearch.css
Lines 497 to 500 in e767b90
Which I left because I didn't know what it affected. But I can deliver that later if wanted.